Fix race condition in project directory creation#358
Merged
Conversation
cigamit
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a race condition when multiple task replicas attempt to create settings.PROJECTS_ROOT simultaneously, which could previously raise FileExistsError during project lock acquisition.
Changes:
- Replace
os.path.exists(...)+os.mkdir(...)with an atomic, idempotent directory creation call usingos.makedirs(..., exist_ok=True).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing with multiple task replicas I noticed this error
Looking upstream it was also just reported in ansible/awx#16456
This small change will fix the race condition. We already include in Pathlib, so a more modern fix might be
but I will keep with what is currently the norm in the codebase for now.